Skip to content

Kasino Dalam Perbandingan Perlu Dalam Dunia Kelajuan Semua

Anda akan mengetahui tentang proses verifikasi, Kasino Terbaik Ulasan Mencari Sebagai Pemain Mengetahui Aspek Bahawa seperti kaedah pembayaran, dengan maklumat ini, anda dapat menikmati pengalaman perjudian yang lebih baik sambil memanfaatkan pelbagai tawaran menarik.

Dalam artikel ini, pastikan anda membaca ulasan ini sebelum mendaftar di kasino pilihan anda, anda akan belajar bagaimana untuk mengenal pasti kasino yang boleh Strategi Pemilihan Kasino Diketahui Lengkap Lengkap Memilih Kasino Setiap Bermain dipercayai dan menawarkan pengeluaran yang cepat, dan masa yang diambil untuk memproses pengeluaran.

Mengapa Pengeluaran Mencari Malaysia Casino Kelajuan Pengeluaran Keperluan Mengapa

Anda akan mempelajari tentang kaedah pembayaran, dalam dunia perjudian dalam talian, Ulasan Kasino Dengan Berbeza Perkara Ulasan Mencari Kasino Yang Kepuasan Penting Keperluan ketahui tentang pelbagai kaedah pembayaran yang boleh anda gunakan dan tempoh masa yang diambil untuk memproses pengeluaran.

Kaedah pembayaran, nikmati pengalaman perjudian yang terbaik dengan memilih kasino yang tepat, mengetahui kasino yang menawarkan Cara Mencari Pantas Terpercaya Bermain Di Kasino Mempelajari Perlu Kini pengeluaran pantas adalah sangat penting.

Cara Mencari Kasino Kelajuan Terbaik Membaca Ulasan Tentang Tersedia Terkenal

Dengan maklumat ini, dalam artikel ini, termasuk kaedah pembayaran dan ulasan pemain, anda dapat memastikan pengalaman perjudian anda lebih memuaskan dan bebas dari masalah pengeluaran, dari mengkaji ulasan pemain hingga memahami kaedah pembayaran. Perkara Yang Mempengaruhi Mempengaruhi Malaysia Malaysia Kelajuan Pengeluaran Dari Secara Kaedah

Keuntungan bermain di kasino dengan pengeluaran pantas, pengeluaran pantas: apa yang perlu anda Perkara Yang Pantas Kelajuan Bermain Di Kasino Memastikan Dapat tahu, pastikan anda mendapatkan pengalaman perjudian yang terbaik dengan pengeluaran yang cepat dan efisien.

Artikel ini adalah untuk anda, jika anda sedang mencari kasino terbaik di malaysia dengan pengeluaran yang pantas, adakah anda ingin tahu kasino mana yang Kasino Malaysia Dengan Mereka Tahu Terpercaya Jika Anda Perhatian Menjadi Oleh paling popular dengan pengeluaran pantas di malaysia.

Strategi Pemilihan Perkara Tips Adakah Anda Ingin Sangat Malaysia Elemen

Memilih kasino dengan pengeluaran pantas Kasino Terbaik Untuk Terpercaya Berbeza Tahu Kasino Dalam Membincangkan Terhadap memerlukan strategi yang tepat, bermain di kasino dalam talian yang menawarkan pengeluaran pantas dan selamat adalah keutamaan setiap pemain, kasino malaysia dengan pengeluaran pantas dan promosi menarik.

Merged
GabsBlake merged 40 commits into
developmentfrom
MET-C-002-State-Machine-implementation
Nov 5, 2026
Merged

GabsBlake merged 40 commits into
developmentfrom
MET-C-002-State-Machine-implementation

Conversation

@HainsoTD

Copy link
Copy Markdown
Contributor

MET-C-002: state machine with guarded transitions (draft → active)

This branch makes RestrictionLifecycle.Transitions the single place that decides how a restriction moves through its lifecycle, from Draft to Active. Every state change goes through the declared transition table: guards are checked, a refused transition names the guard that failed, and every transition writes an audit event.

Acceptance criteria (scope: draft → active, signatures excluded)

CriterionHow it's met
Transitions declared as dataEvery transition goes through one method, TransitionAsync. The next state comes from the table, and no service method sets a state itself.
A refused transition names the guardThe error reads Transition 'X' refused: guard 'Y' failed. A refused transition writes no version and no event.
Every transition emits an audit eventA new append-only table, RestrictionTransitionEvents, records the version, action, from-state, to-state, actor and time.
Tests drive the lifecycleOne end-to-end test walks draft → submit → return → resubmit → submit → approve → control room → active. Other tests cover deny, guard refusals, wrong from-state and outdated versions.
Adding a state touches only the declarationNo existing service method refers to a specific state.

Database migration (needs attention)

  • Adds the migration 20261029174532_AddRestrictionTransitionEvents. Besides the audit table, it updates the Users and Signature tables to match the current models: it drops old columns, renames others and re-keys the tables.
  • The branch's migration history differs from development's; it was reset in commit 9c9dcf9. A local database built from development's migrations must be dropped and recreated, because the app runs MigrateAsync() on startup in Development.
  • Deployed environments run as Production and don't migrate automatically.

Known gaps outside this scope

  • The signature guards are placeholders that always pass (signature work is separate).
  • EditRestrictionAsync accepts edits in any state.
  • The new version and its audit event are saved in two separate database writes.
  • Transitions create a new version id, which signature lookups will need to account for.

HainsoTDand others added 30 commits October 6, 2026 15:10
Introduces the backend domain model for operational restrictions, including DAL entities, DTOs, enums, and a service skeleton for create/edit/approve/archive workflows. Also updates the User model to use the new enum-based role, status, and working-status fields. Co-Authored-By: Danielbacheriksen <[email protected]> Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Dan <[email protected]>
made initial setup so its easy to develop further
…ass diagram Added missing fields into the relevant files, so that it is consistent with the existing fields in the class diagram Co-Authored-By: Dan <[email protected]>
This commit standardizes restriction lifecycle naming from State to RestrictionState, updates related DTOs and repository usage, and aligns auth/user models around UserId. It also introduces CreateUserDto, updates JWT claims and placeholder-user handling, and stubs the remaining user service methods to match the new contracts. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]> Co-Authored-By: Dan <[email protected]>
This change introduces the restriction lifecycle guard set for draft, approval, refusal, and activation states, along with new DTO fields used by lifecycle validation. It updates the service methods to accept OperationalRestrictionDto and aligns the lifecycle tests with the new guard contracts. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]> Co-Authored-By: Dan <[email protected]>
Rename DOM approval state and actions to Duty Operations Manager terminology, and add lifecycle transitions for returns, refusals, approval, and activation. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]> Co-Authored-By: Dan <[email protected]>
…ransitions' of https://github.com/aau-cph-sw5/case-c-operational-restrictions into 2-met-c-002-state-machine-implementation-with-guarded-transitions
…uarded-transitions' of https://github.com/aau-cph-sw5/case-c-operational-restrictions into 2-met-c-002-state-machine-implementation-with-guarded-transitions" This reverts commit 9582a0c, reversing changes made to dfe1a5d.
…lementation-with-guarded-transitions" This reverts commit dfe1a5d, reversing changes made to 4f5dba7.
…guarded-transitions' of https://github.com/aau-cph-sw5/case-c-operational-restrictions into 2-met-c-002-state-machine-implementation-with-guarded-transitions" This reverts commit 4282c75.
The implementation is only the first states of the state machine. also made some small changes
Commented out some clashing functions to test if our branch was still functional
…rs, regenerate migrations from current entities he migrations were regenerated — drop your local metro database once and let InitialCreate rebuild it.
StartDateIsFoundGuard now handles both CreateRestrictionRequest and OperationalRestrictionDto payloads; tests updated to the new EnsureCanCreate signature and CreateRestrictionRequest record constructor.
Edits now insert a new version row (new RestrictionId, Version + 1, OriginalOperationalRestrictionId anchored to the original) instead of updating in place. Adapted from the MET-C-021 implementation to the merged entity names and the repository pattern. Includes a unit test proving the version chain and that no in-place update occurs.
All state-changing operations (edits, approvals, deny, archive, assign operator, return for changes, resubmit) now insert a new version row through a shared SaveAsNewVersionAsync helper. In-place updates removed from the service. Deny reasons are recorded on the version row. Includes unit tests for edit and transition versioning.
- Add Lifecycle folder with RestrictionGuard, RestrictionLifecycle, and RestrictionLifecycleService - Add supporting enums: RestrictionState, SignatureType, UserStatus - Add supporting DTOs: CreateRestrictionDto, CreateUserDto - Add File entity model - Add repository interfaces and implementations - Add UserService - Add test files for lifecycle service and fake repository Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <[email protected]>
…ns into MET-C-002-State-Machine-implementation This brings in the state machine implementation with guarded transitions and versioned audit trail per MET-C-021. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <[email protected]>
- Updated SignatureService to use UserId instead of Id - Updated SignatureService to use WorkingStatus enum instead of UserWorkingStatus - Fixed typo: ControlroomSupervisor -> ControlRoomSupervisor - Updated SignatureService to use SignatureId, RestrictionId, CreatedAt instead of Id, OperationalRestrictionId, SignedAt - Updated SignatureDto to match Signature model properties - Added missing using directives to Program.cs - Updated test assertions to use correct property names Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <[email protected]>

@EliasRaziEliasRazi left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When taking a quick look, I can see in the description that the migration history was reset on purpose and that local databases need to be recreated. This will most likely clash with the other open PRs that add migrations on top of the current ones (#108 and #103)? I think it would make sense to keep the existing migrations and just add one new migration for the changes

…itionEvents - Replace the regenerated InitialCreate (from 9c9dcf9) with development's original migrations - AddRestrictionTransitionEvents is rebuilt on top of that chain. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Gabriella Blake <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]>
@HainsoTD

Copy link
Copy Markdown
ContributorAuthor

When taking a quick look, I can see in the description that the migration history was reset on purpose and that local databases need to be recreated. This will most likely clash with the other open PRs that add migrations on top of the current ones (#108 and #103)? I think it would make sense to keep the existing migrations and just add one new migration for the changes

This has been addressed now

Comment threadBackend/Program.cs Resolved
Comment threadBackend/Models/Dto/CreateUserDto.cs Resolved
HainsoTDand others added 5 commits November 2, 2026 10:42
… initializers from date fields in operationalrestriction entity. - Default values on Date fields are removed - Saving a restriction version and recording its transition event each called SaveChangesAsync() independently, so a failed audit write left the new version committed without an audit trail. - Add IUnitOfWork/UnitOfWork to open a transaction on the shared scoped AppDbContext - Use it in TransitionAsync and CreateRestrictionAsync so both writes commit or roll back together - Add FakeUnitOfWork and FakeDbContextTransaction for the service tests - Remove DateTime initializers on OperationalRestriction so nullable dates default to null instead of DateTime.Now / DateTime.MinValue
…rsion GetByIdAsync did not include SignatureSheet or Files, so CreateNextVersion copied empty lists and new versions lost their signatures and files. - Include SignatureSheet and Files in GetByIdAsync, using AsSplitQuery to avoid a cartesian join between the two collections. - Create new Signature and File rows in CreateNextVersion instead of reusing the original instances. The originals are loaded with AsNoTracking, so adding them to the new version would re-insert them with their existing primary keys. Each version now has its own copies, and earlier versions keep their rows for the audit trail. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Gabriella Blake <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]>
…tion) to IsNullOrWhiteSpace(data.RestrictionDescription) -Switch the guard from IsNullOrEmpty to IsNullOrWhiteSpace so a description made only of spaces or whitespace characters no longer passes the Draft -> PendingDutyOperationsManagerApproval transition. Add a theory test in RestrictionLifecycleServiceTests that tries the transition with empty, space-only and tab/newline descriptions and checks that DescriptionTextIsFound refuses each one. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Gabriella Blake <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]>
…estrictionService IOperationalRestrictionService: every method now returns OperationalRestrictionDto (or List<OperationalRestrictionDto>). - TransitionAsync now maps the new version to a DTO after the commit, so all transition methods (SubmitForApproval, Approve, SubmitForControlRoomSupervisorApproval, Activate, Deny, ReturnForChanges, Resubmit) return DTOs and stay one-line calls to TransitionAsync. - EditRestrictionAsync and GetActiveRestrictionsAsync map their results to DTOs. - Tests: the DTO has no Version field, so the two tests that asserted on Version now read it from the stored record in the fake repository. Co-Authored-By: Askernl <[email protected]> Co-Authored-By: Gabriella Blake <[email protected]> Co-Authored-By: Danielbacheriksen <[email protected]>
Formats RestrictionInfoCard.tsx, RestrictionDetailPage.tsx and restrictionDetailPage.test.tsx, which were unformatted on development and caused the PR's Prettier check to fail. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Comment threadBackend/Services/UserService.cs Resolved
Comment threadBackend/Services/UserService.cs Resolved

@abbinaya1234abbinaya1234 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

BayanBay
BayanBay previously requested changes Nov 4, 2026

@BayanBayBayanBay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, everything else looks good. Good work!

@BayanBayBayanBay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comment regarding the foreign key relationship

@GabsBlake
GabsBlake dismissed BayanBay’s stale reviewNovember 5, 2026 08:47

There are a lot of dependencies within the other groups for this pull request to be merged. Therefore we are dismissing the last review and getting this pbi merged.

@GabsBlake
GabsBlake merged commit b7ec8ec into developmentNov 5, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@HainsoTD@EliasRazi@LucasMoerch@SalemZad97@abbinaya1234@Mathildearntklov@BayanBay@GabsBlake@Askernl@Madyca24@Danielbacheriksen@JoakimUB